CLN: remove BlockManager.get #33052
Merged
CLN: remove BlockManager.get #33052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Looks good - any perf implications? |
_getitem_multilevel calling _ixs instead of _get_item_cache is slightly higher-level, and we lost a little ground on the columns.is_unique assertions, then make up some ground with unnecessary checks in BlockManager.get being removed. It's about a wash. |
jreback
added
the
Indexing
|
Updated so as to not be blocked by #33047. |
WillAyd
approved these changes
Apr 14, 2020
jbrockmendel
added
Internals
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
* CLN: remove BlockManager.get * Remove assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged until after #33047 and #33045, since the assertions made here will not always hold until then.